Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiarch container builds #518

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add multiarch container builds #518

merged 1 commit into from
Nov 15, 2022

Conversation

arbourd
Copy link
Contributor

@arbourd arbourd commented Nov 10, 2022

Description

Uses docker manifests to build 2 separate images, one per arch, pushes them both, and then combines them with common tags, as per the docs: https://goreleaser.com/customization/docker_manifest/

Fixes #440

Type of change

  • CI/Build

Version of Golang used when building/testing:

  • 1.18

How Has This Been Tested?

Ran locally and built the images with GoReleaser.

  • docker images
    • building docker image                          image=vektra/mockery:v2.14.1-arm64
    • building docker image                          image=vektra/mockery:v2.14.1-amd64
    • took: 15s

The manifests command doesn't run unless the release actually happens.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Uses docker manifests to build 2 seperate images, one per arch, pushes
them both, and then combines them with a common title, as per the docs:
https://goreleaser.com/customization/docker_manifest/
@codecov-commenter
Copy link

Codecov Report

Base: 72.42% // Head: 72.42% // No change to project coverage 👍

Coverage data is based on head (e9abbc5) compared to base (94c17ff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files           6        6           
  Lines        1262     1262           
=======================================
  Hits          914      914           
  Misses        304      304           
  Partials       44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp LandonTClipp merged commit 1951b28 into vektra:master Nov 15, 2022
@arbourd arbourd deleted the add-multiarch-builds branch November 15, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make docker images for linux arm64
3 participants