Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support go 1.20 #536

Merged
merged 2 commits into from
Feb 3, 2023
Merged

support go 1.20 #536

merged 2 commits into from
Feb 3, 2023

Conversation

dillonstreator
Copy link
Contributor

@dillonstreator dillonstreator commented Feb 1, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

Copy link

@bastianccm bastianccm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dillonstreator , I think github actions parse 1.20 as a number, and initialize the pipeline with go 1.2 instead of go 1.20.
Passing this as a string should help.

image

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
@LandonTClipp LandonTClipp merged commit 3882a4c into vektra:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go 1.20 internal error: package "..." without types was imported from "..."
3 participants