Custom Fields: External ID support (AG-1605) #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using
fieldID
to reference a custom field it's hard because it's basically a computer generated UUID (e.g.FieldID-5227880d-0916-4048-a128-3b0930903c5f
).To make the life who is consuming Vendasta's external API easier this PR add supports to an alternative identifier, the External ID.
Solution
Basically the solution is all handled by our internal API's,
api-gateway
just have to accept the attribute ExternalID as an identifier for custom fields on theUpsert
operations.Upsert example:
List example:
Notes
I had to remove
fieldId
's required flag, and I couldn't find a schema that wouldfieldId
orexternalId
mandatory. There some discussion here, but it looks like it's dead end.@vendasta/np-easy
@richard-rance
AG-1605