Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes HTTP status codes not recorded when not 200. #74 #75

Merged
merged 3 commits into from
Feb 14, 2018
Merged

Fixes HTTP status codes not recorded when not 200. #74 #75

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0eb3af
Fixes HTTP status codes not recorded when not 200. #74
Oct 31, 2017
7feedc9
updating travis osx_image to 9
Nov 1, 2017
8e7e591
Merge branch 'master' into hotfix/status-codes-not-recorded-74
sethhoward Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
language: objective-c # lol
osx_image: xcode8.2
osx_image: xcode9.1
xcode_project: DVR.xcodeproj

script: xcodebuild -scheme "$TRAVIS_XCODE_SCHEME" -sdk "$TRAVIS_XCODE_SDK" -destination "$DESTINATION" test
Expand Down
2 changes: 1 addition & 1 deletion DVR/Interaction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ extension Interaction {

var responseDictionary = self.response.dictionary

if let httpResponse = response as? HTTPURLResponse {
if let httpResponse = response as? Foundation.HTTPURLResponse {
responseDictionary["headers"] = httpResponse.allHeaderFields
responseDictionary["status"] = httpResponse.statusCode
}
Expand Down