Debug status code not being recorded #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2018
Closed
|
This PR is ready for review @dmiluski @eliperkins |
|
Is the fix in here? It looks like the only changes are in the test files. |
|
Hmm, maybe it got lost during rebase...i saw that #75 was merged some time ago, but my fork was still not working. Maybe it's worthwhile to simply add this test and publish a new version? |
|
Yeah, adding this test seems kosher to me, especially since it's passing. |
eliperkins
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74 & #69
This PR fixes a regression that caused the http status code and http headers to not be recorded in the case of non-200 responses. I've added a test to avoid future regressions.