add reader role (#28)

venturemark · May 3, 2021 · 12f17d9 · 12f17d9
1 parent 6899187
commit 12f17d9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/pkg/ingress/ingress_test.go b/pkg/ingress/ingress_test.go
@@ -164,6 +164,15 @@ func Test_Ingress_Match_false(t *testing.T) {
 				role.Member,
 			},
 		},
+		// Case 18
+		{
+			l: []label.Label{
+				resource.Message,
+				visibility.Private,
+				action.Create,
+				role.Reader,
+			},
+		},
 	}
 
 	for i, tc := range testCases {
@@ -300,6 +309,15 @@ func Test_Ingress_Match_true(t *testing.T) {
 				role.Owner,
 			},
 		},
+		// Case 12
+		{
+			l: []label.Label{
+				resource.Message,
+				visibility.Private,
+				action.Search,
+				role.Reader,
+			},
+		},
 	}
 
 	for i, tc := range testCases {

diff --git a/pkg/ingress/policy.go b/pkg/ingress/policy.go
@@ -27,6 +27,7 @@ var (
 		{role.Any /*******/, action.Search /***/, visibility.Public /****/, resource.Any /********/},
 		{role.Member /****/, action.Search /***/, visibility.Private /***/, resource.Any /********/},
 		{role.Owner /*****/, action.Search /***/, visibility.Private /***/, resource.Any /********/},
+		{role.Reader /****/, action.Search /***/, visibility.Private /***/, resource.Any /********/},
 
 		{role.Owner /*****/, action.Update /***/, visibility.Any /*******/, resource.Any /********/},
 	}

diff --git a/pkg/label/role/subject.go b/pkg/label/role/subject.go
@@ -6,5 +6,6 @@ const (
 	Any     label.Label = "role:any"
 	Member  label.Label = "role:member"
 	Owner   label.Label = "role:owner"
+	Reader  label.Label = "role:reader"
 	Subject label.Label = "role:subject"
 )