Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added in audience scaffolding #124

Merged
merged 7 commits into from
Jan 22, 2021
Merged

added in audience scaffolding #124

merged 7 commits into from
Jan 22, 2021

Conversation

marcusellison
Copy link
Contributor

@marcusellison marcusellison commented Jan 21, 2021 •
edited
Loading

  • poc audience create call.

@marcusellison marcusellison requested a review from a team January 21, 2021 02:53
@marcusellison marcusellison self-assigned this Jan 21, 2021
@xh3b4sd
Copy link
Contributor

xh3b4sd commented Jan 21, 2021

I'm current blocked because apigents release is outdated.

It cannot be outdated, I just ported it over in #121. Let's talk later what the problem here is about.

Also, how is frontend intended to manage users of an audience?

The solution I implemented in the backend does not align anymore with our recent decisions. So this needs some work in the backend. Let's talk later.

@marcusellison marcusellison merged commit a269cf6 into main Jan 22, 2021
@marcusellison marcusellison deleted the audience branch January 22, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusellison marcusellison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusellison @xh3b4sd