Skip to content
This repository has been archived by the owner on Jun 2, 2018. It is now read-only.

[WIP] Add Dash router to benchmarks #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

tyler-sommer
Copy link
Member

Requested by @Ocramius #1

@DASPRiD
Copy link

DASPRiD commented Feb 26, 2014

As for that service locator requirement: You can simply implement the route collection interface with a simple implementation for your benchmark.

@tyler-sommer
Copy link
Member Author

@DASPRiD Heh, apologies for missing that.

I implemented a custom RouteCollection and everything is working fantastic, but I'm curious about the results. I'm hoping you would take a look at how I'm setting things up -- perhaps I've made a mistake?

@DASPRiD
Copy link

DASPRiD commented Feb 27, 2014

Well, first off, you always only test the matching performance, and completely ignore the instantiation. This is kinda important, since usually for every match you also have the instantiation time (one match per request). This already makes it a little unfair, since Dash is quite performant in regard to that; see the following benchmark:

https://github.com/DASPRiD/RouterBenchmark

Apart from that, your benchmark makes absolutely no use of some of the key features of Dash, which involve heavy lazy loading and re-using of resources.

@tyler-sommer
Copy link
Member Author

Thanks, @DASPRiD. You're right, I am only testing matching performance. I do intend to extend the tests to cover instantiation and caching and whatever else-- just needed a place to start.

I will take a look at your benchmark to see some ways I can leverage Dash's features in these tests. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants