-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance individual UT in go-cose library to handle specific errors #137
Conversation
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@shizhMSFT and @qmuntal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and nice!
@yogeshbdeshpande, can you fix the signing? Learn more about signing commits. |
Assigning to @yogeshbdeshpande to complete. |
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 92.12% 93.49% +1.36%
==========================================
Files 10 10
Lines 978 1076 +98
==========================================
+ Hits 901 1006 +105
+ Misses 51 47 -4
+ Partials 26 23 -3 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixes #138
Signed-off-by: Yogesh Deshpande yogesh.deshpande@arm.com