Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance individual UT in go-cose library to handle specific errors #137

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

yogeshbdeshpande
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande commented Feb 22, 2023

Fixes #138

Signed-off-by: Yogesh Deshpande yogesh.deshpande@arm.com

Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review February 22, 2023 17:59
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yogeshbdeshpande
Copy link
Contributor Author

@shizhMSFT and @qmuntal
Request please review as well...

Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and nice!

@SteveLasker
Copy link
Contributor

@yogeshbdeshpande, can you fix the signing? Learn more about signing commits.
@shizhMSFT, can you please review?

@SteveLasker
Copy link
Contributor

Assigning to @yogeshbdeshpande to complete.

@SteveLasker SteveLasker added this to the v1.1.0 milestone Mar 10, 2023
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #137 (08fc5f0) into main (c6971fb) will increase coverage by 1.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   92.12%   93.49%   +1.36%     
==========================================
  Files          10       10              
  Lines         978     1076      +98     
==========================================
+ Hits          901     1006     +105     
+ Misses         51       47       -4     
+ Partials       26       23       -3     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yogeshbdeshpande yogeshbdeshpande merged commit 3b32cdb into main Mar 10, 2023
@SteveLasker SteveLasker deleted the ut-corrections branch March 24, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further work: Unit Test in go-cose repository needs to check for precise error condition
5 participants