Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix codecov #200

Merged
merged 1 commit into from
Aug 15, 2024
Merged

build: fix codecov #200

merged 1 commit into from
Aug 15, 2024

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Aug 15, 2024 •
edited
Loading

Fix #199

  • upgrade codecov-action to v4
  • provide CODECOV_TOKEN

@shizhMSFT
build: fix codecov
85814eb 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
yogeshbdeshpande
yogeshbdeshpande approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (2b6f94f) to head (85814eb).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   92.04%   92.35%   +0.31%     
==========================================
  Files          12       12              
  Lines        1973     1622     -351     
==========================================
- Hits         1816     1498     -318     
+ Misses        108       68      -40     
- Partials       49       56       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT
Copy link
Contributor Author

To completely fix #199, admins of this repository are requested to set the CODECOV_TOKEN in the repository secret.
image
The CODECOV_TOKEN secret is required to be set in both Actions and Dependabot.

@shizhMSFT
Copy link
Contributor Author

@thomas-fossati @yogeshbdeshpande The CODECOV_TOKEN can be found at https://app.codecov.io/gh/veraison/go-cose/config/general

@SteveLasker SteveLasker merged commit 49d22c7 into veraison:main Aug 15, 2024
4 checks passed
@shizhMSFT shizhMSFT deleted the fix_codecov branch August 16, 2024 15:33
@shizhMSFT shizhMSFT mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLasker SteveLasker SteveLasker approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@henkbirkholz henkbirkholz Awaiting requested review from henkbirkholz henkbirkholz is a code owner

@qmuntal qmuntal Awaiting requested review from qmuntal qmuntal is a code owner

@roywill roywill Awaiting requested review from roywill roywill is a code owner

@setrofim setrofim Awaiting requested review from setrofim setrofim is a code owner

@SimonFrost-Arm SimonFrost-Arm Awaiting requested review from SimonFrost-Arm SimonFrost-Arm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Coverage is broken
4 participants
@shizhMSFT @SteveLasker @thomas-fossati @yogeshbdeshpande