Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark COSE Sign as experimental #58

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Conversation

thomas-fossati
Copy link
Contributor

Fix #55

@thomas-fossati thomas-fossati self-assigned this Apr 22, 2022
@thomas-fossati thomas-fossati requested a review from a team April 22, 2022 22:44
Fix #55

Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@SteveLasker
Copy link
Contributor

Just thinking typing out loud: should we add,

sign1 has full test suites and security reviews

to the comments? Or, is that too much? And, we can do that in the readme.

@thomas-fossati
Copy link
Contributor Author

Just thinking typing out loud: should we add,

sign1 has full test suites and security reviews

to the comments? Or, is that too much? And, we can do that in the readme.

I think adding that to each code comment would be a tad too heavy.

Apropos of COSE_Sign, the README says : "[...] In addition, the amount of functional and security testing it has received so far is significantly lower than the COSE_Sign1 API." which seems to capture the same semantics as you suggest above, although in reverse.

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yogeshbdeshpande yogeshbdeshpande merged commit 0475594 into main Apr 23, 2022
@shizhMSFT shizhMSFT deleted the COSE_Sign-is-experimental branch April 24, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document sign as experimental
4 participants