fix: make tsm-report JSON-friendly #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-fossati
requested review from
cowbon,
deeglaze,
iolivergithub and
jraman567
as code owners
deeglaze
approved these changes
Oct 5, 2024
jraman567
reviewed
Oct 6, 2024
|
Thanks for this PR, @thomas-fossati . It looks good, except for the service_provider comment I made above. Thanks, @deeglaze , for reviewing this also. |
Thanks, @jraman567 - I will refrain from hitting the send button to kick off the registration until we confirm the behaviour. Since this change only focuses on adding the JSON serialisation, we can merge this and raise an issue to track the testing/confirmation activity. (Edit: tracking issue #8) |
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org> Co-authored-by: Dionna Amalie Glaze <drdeeglaze@gmail.com>
thomas-fossati
force-pushed
the
json-friendly-tsm-report
branch
from
d7fcc0e to
4712983
Compare
|
@thomas-fossati That sounds good to me. I'll mark my comment as "Resolved" as we track the issue separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.