Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the chat request options for useChat across all frameworks #859

Merged
merged 10 commits into from
Dec 19, 2023

Conversation

lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented Dec 13, 2023

Warning

This change breaks cases where the existing options are used in useChat for vue and solid.

Summary

  • add chat request options to useChat / solid
  • add chat request options to useChat / vue

@lgrammel lgrammel self-assigned this Dec 13, 2023
@lgrammel lgrammel changed the title [WIP] Align chat request options in useChat for all frameworks Align the chat request options for useChat across all frameworks Dec 14, 2023
@lgrammel lgrammel changed the title Align the chat request options for useChat across all frameworks [Stacked] Align the chat request options for useChat across all frameworks Dec 14, 2023
@lgrammel lgrammel changed the title [Stacked] Align the chat request options for useChat across all frameworks Align the chat request options for useChat across all frameworks Dec 15, 2023
@lgrammel lgrammel requested a review from MaxLeiter December 15, 2023 12:43
@lgrammel lgrammel marked this pull request as ready for review December 15, 2023 12:43
Comment on lines -148 to -150
// @deprecated
functions?: Array<Function>;
// @deprecated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup some of the tools changes. Do we want to deprecate functions?

@MaxLeiter MaxLeiter merged commit ac503e0 into vercel:main Dec 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants