-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align the chat request options for useChat across all frameworks #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrammel
changed the title
[WIP] Align chat request options in useChat for all frameworks
Align the chat request options for useChat across all frameworks
Dec 14, 2023
lgrammel
changed the title
Align the chat request options for useChat across all frameworks
[Stacked] Align the chat request options for useChat across all frameworks
Dec 14, 2023
lgrammel
changed the title
[Stacked] Align the chat request options for useChat across all frameworks
Align the chat request options for useChat across all frameworks
Dec 15, 2023
lgrammel
commented
Dec 15, 2023
Comment on lines
-148
to
-150
// @deprecated | ||
functions?: Array<Function>; | ||
// @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup some of the tools changes. Do we want to deprecate functions?
MaxLeiter
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This change breaks cases where the existing options are used in
useChat
forvue
andsolid
.Summary