Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Round and Updates #719

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Bug Fix Round and Updates #719

merged 4 commits into from
Mar 24, 2022

Conversation

okbel
Copy link
Contributor

@okbel okbel commented Mar 23, 2022

  • This PR adds a missing dependency for Kibo Commerce Add to cart throwing 500 error #682
  • removed dead and unused code
  • refactored how we handle missing pages. It's now returning 404 instead of throwing on the build. This is something we could discuss because there are valid 404 (even on build) and there are definitely worrying situations when something should be and is not present. This will fix 404 page is not loading #468
  • refactored types for pages. I get flaky errors on a few builds around those types returning never.
next-commerce:build: (node:919) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'pages' of undefined
next-commerce:build: TypeError: Cannot read property 'pages' of undefined
next-commerce:build: (node:926) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'collections' of undefined

@okbel okbel added the bug Something isn't working label Mar 23, 2022
@okbel okbel requested a review from dominiksipowicz March 23, 2022 16:05
@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

commerce-local – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/HV8gw9DACvtkr1M3MtHK4rvfyYWV
✅ Preview: https://commerce-local-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-shopify – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-shopify/3j4QjikhaXPeyvAM8EbBEJ8gfzdv
✅ Preview: https://commerce-shopify-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-ordercloud – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-ordercloud/FgkEmNk1Nt9y6zPX4MwDJQJ7QVJA
✅ Preview: https://commerce-ordercloud-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-bigcommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-bigcommerce/AFmbQx7t6K5Jbq4B5CYzyt4VjSda
✅ Preview: https://commerce-bigcommerce-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-commercejs – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-commercejs/7Gy6X8UecxuFY9NurUr8PW8hMEtb
✅ Preview: https://commerce-commercejs-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-spree – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-spree/6ZENudCA5SaJD6cWdj9yMUCLJJrt
✅ Preview: https://commerce-spree-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-kibocommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-kibocommerce/45zcJxttmWrRYWFc6TkQJadQVCKh
✅ Preview: https://commerce-kibocommerce-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-vendure – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-vendure/HQaHBAaz5K6Y6Cpvz7c9kXUYaSo6
✅ Preview: https://commerce-vendure-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-swell – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-swell/FEB6bkCqUHcxxX9SEXkZo9zCg9j8
✅ Preview: https://commerce-swell-git-kib-deps-vercel-solutions-vtest314.vercel.app

commerce-saleor – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-saleor/9isuCczbFgeArMEv1jowTF6gEAxx
✅ Preview: https://commerce-saleor-git-kib-deps-vercel-solutions-vtest314.vercel.app

@dominiksipowicz dominiksipowicz merged commit 52b25b8 into main Mar 24, 2022
@dominiksipowicz dominiksipowicz deleted the kib-deps branch March 24, 2022 11:42
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
@ashishkpaul
Copy link

Hello sir in spree/commerce its not fetching the products from menu links. is there any solution
i tried app link https://commerce-spree-git-kib-deps-vercel-solutions-vtest314.vercel.app/
and also on the fresh deployment showing the same results

spree-vercel

loan-laux pushed a commit to TrellisCommerce/next-commerce-bigcommerce that referenced this pull request May 11, 2023
* Kibo missing dependency
* return 404 for invalid page
* fix and simplify types for pages

Co-authored-by: Dominik Sipowicz <dom@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page is not loading
3 participants