Add support for Apple Silicon and other ARM builds #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/hazel/ELnxSWJLDRHzy9CbVqEHsNaUB5wF |
leo
suggested changes
Jul 20, 2021
|
@leo I have updated with requested changes |
leo
suggested changes
Jul 23, 2021
Co-authored-by: Leo Lamprecht <mindrun@icloud.com>
leo
suggested changes
Jul 23, 2021
leo
reviewed
Jul 23, 2021
| @@ -81,6 +81,10 @@ module.exports = ({ cache, config }) => { | |||
| platform = 'dmg' | |||
| } | |||
|
|
|||
| if (platform === 'mac_arm64' && !isUpdate) { | |||
There was a problem hiding this comment.
It's for the zip issue on mac os
Similar to lines 80-82 for x64
Co-authored-by: Leo Lamprecht <mindrun@icloud.com>
leo
changed the title
leo
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arm build assets as a separate platform, to avoid overwriting x64.