Skip to content

Commit

Permalink
Ditch yarn
Browse files Browse the repository at this point in the history
  • Loading branch information
@matheuss
matheuss committed Feb 15, 2017
1 parent 6842e85 commit 70822a3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ before_install:
- mkdir -p /tmp/git-lfs && curl -L https://github.com/github/git-lfs/releases/download/v1.2.1/git-lfs-$([ "$TRAVIS_OS_NAME" == "linux" ] && echo "linux" || echo "darwin")-amd64-1.2.1.tar.gz | tar -xz -C /tmp/git-lfs --strip-components 1 && /tmp/git-lfs/git-lfs pull
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then export DISPLAY=:99.0; sh -e /etc/init.d/xvfb start; sleep 3; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install yarn; fi

install:
- yarn
- npm install

before_script:
- npm prune
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ install:
- ps: Install-Product node 6 x64
- set CI=true
- npm -g install npm@latest
- yarn
- npm install

build: off

Expand Down

8 comments on commit 70822a3

@john-kurkowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Should this remove yarn.lock too?

@albinekb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? @matheuss

@gsklee
Copy link
Contributor

@gsklee gsklee commented on 70822a3 Feb 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauchg @leo Can somebody look into this change? A less robust dependency management?

@stefanivic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-kurkowski @albinekb @gsklee as far as i remember, there was some issue regarding the building process and caused the builds to fail using yarn. But don't quote me on this one.

@matheuss
Copy link
Member Author

@matheuss matheuss commented on 70822a3 Feb 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing on CI: https://travis-ci.org/zeit/hyper/jobs/202036801#L378
¯_(ツ)_/¯

@gsklee
Copy link
Contributor

@gsklee gsklee commented on 70822a3 Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheuss I've opened up an issue at Yarn; would you be willing to fill in more details over there? yarnpkg/yarn#2750

@gsklee
Copy link
Contributor

@gsklee gsklee commented on 70822a3 Feb 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauchg @matheuss From the information I gathered, and the feedback provided by yarn devs inside my reported issue, it seems to be a one-time network error only, and can be easily mitigated by some preventive measurements like retrying. I think there are better ways to handle this than simply ditching the tool.

@matheuss
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsklee I'd be happy to receive a PR 👌 Not sure about how to handle retying and whatnot within Travis/AppVeyor

Please sign in to comment.