Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu is showing Hyper but trows an error when clicked #1165

Closed
lednhatkhanh opened this issue Dec 13, 2016 · 8 comments
Closed

Context menu is showing Hyper but trows an error when clicked #1165

lednhatkhanh opened this issue Dec 13, 2016 · 8 comments
Labels
🖼 Platform: Windows Issue pertains to Windows

Comments

@lednhatkhanh
Copy link

lednhatkhanh commented Dec 13, 2016

This issue's related to this: #1133

I'm facing this issue on windows 10 when I build the app from source (latest commit, master).

But, after removing and reinstall using the .exe file downloaded from here, it started working fine.

Nodejs: 7.2.1 64 bit
Windows 10 64bit.

Note that this also happends with GritKraken (another Electron app), so I think that there should be some problems with Electron or something. Vscode's still working fine tho.

@kilianso
Copy link

kilianso commented Dec 13, 2016

To solve this until it's fixed by an update:

Step 1 : Type "regedit" in start menu

Step 2 : Run the registry editor

Step 3 : Navigate to HKEY_CURRENT_USER\SOFTWARE\Classes\Directory\Background\shell\Hyper\command

Step 4 : Right-click on "REG_SZ" entry and choose modify

Step 5: Enter the Path to Hyper, like: C:\Users\username\AppData\Local\app-1.0.0\Hyper.exe

Unfortunately Hyper doesn't navigate directly to the "open here" directory. This should be fixed too.

@Specro
Copy link
Contributor

Specro commented Dec 13, 2016

@lednhatkhanh Hyper adds/removes the context menu entry only during install/uninstall. That's why your entry may have been broken.

@kilianso I can't seem to reproduce this. Is this on Windows 10? Could you share your config?

@nsna
Copy link

nsna commented Dec 14, 2016

@kilianso opening in the current directory can be fixed by adding "%V" as an argument in the command key:
"C:\Users\<username>\AppData\Local\hyper\app-1.0.0\Hyper.exe" "%V"

You can also change the text that is displayed in the context menu by adding a value to the parent Hyper key such as "Open Hyper Here".

Windows reg export:

Windows Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\Directory\Background\shell\Hyper]
@="Open Hyper Here"

[HKEY_CLASSES_ROOT\Directory\Background\shell\Hyper\command]
@="\"C:\\Users\\<username>\\AppData\\Local\\hyper\\app-1.0.0\\Hyper.exe\" \"%V\""

@linonetwo
Copy link

linonetwo commented Feb 26, 2017

@kilianso
Should use C:\Users\xxx\AppData\Local\hyper\Update.exe --processStart "Hyper.exe" instead of C:\Users\xxx\AppData\Local\app-1.2.1\Hyper.exe, or if you update your hyper, context menu will be outdated.

@shanselman
Copy link

shanselman commented Mar 12, 2017

I just hit this also. The default reg key is getting erased on update. Perhaps something wrong with the squirrel update?

@linonetwo That doesn't seem to work as the path (via %V) isn't passed to Hyper.exe from Squirrel's update.exe. I think that it should be set to the full path, then the update.exe handler should update the reg key on update.

@ghost
Copy link

ghost commented Jul 18, 2017

Somehow the command: "C:\Users<username>\AppData\Local\hyper\app-1.0.0\Hyper.exe" "%V" was not working for me. Hyper showed up but not at the correct path.

So I changed it to:
C:\Users\xxx\AppData\Local\hyper\Hyper.exe --process-start-args="-p %V"

@djalmajr
Copy link

djalmajr commented Aug 2, 2017

@EsSpricht's solution works for me

@Stanzilla Stanzilla added the 🖼 Platform: Windows Issue pertains to Windows label Apr 24, 2018
@Stanzilla
Copy link
Contributor

Fix by #1831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼 Platform: Windows Issue pertains to Windows
Projects
None yet
Development

No branches or pull requests

8 participants