[Windows]Refactor system context menu #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I am concern. I can't test on windows. Could you make a gif of the result (context) or pictures here. |
|
It looks the same as before. I added the picture nevertheless. |
Specro
changed the title
albinekb
reviewed
May 19, 2017
| } | ||
| }); | ||
| }; | ||
|
|
||
| exports.remove = function (callback) { | ||
| isRegistered(registered => { |
There was a problem hiding this comment.
It's not really needed since the destroy function returns an error if it can't find the Hyper key or something else goes wrong. Helps to debug if we get these menu bugs again. Also, less registry requests - faster (un)installation.
|
Tested on Win10. Works really great! No more problem with install/uninstall. |
chabou
approved these changes
May 20, 2017
This was referenced May 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the system context menu code. Now it's less complex and easier to debug in the future. This should fix all these #1734 #1668 #1651 #1133 bugs as far as my testing goes. Any more testing from other Win users always appreciated 😄 Otherwise it's ready for merge.