Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close session conflicts with quit hotkey #2156

Closed
MarkDaviesEsendex opened this issue Sep 1, 2017 · 4 comments
Closed

Close session conflicts with quit hotkey #2156

MarkDaviesEsendex opened this issue Sep 1, 2017 · 4 comments
Labels
💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ good first issue Issue is good for Hyper newcomers 🐧 Platform: Linux Issue pertains to Linux 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@MarkDaviesEsendex
Copy link

Issue

The CTRL+SHIFT+W hotkey is used for both close session and quit meaning that I have to close a tab with x button or middle mouse click
@chabou chabou added 🐧 Platform: Linux Issue pertains to Linux 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper good first issue Issue is good for Hyper newcomers labels Sep 1, 2017
@chabou
Copy link
Contributor

chabou commented Sep 1, 2017

oups 😊
Thank you for your feedback

@louislva
Copy link
Contributor

louislva commented Sep 2, 2017

Would CTRL+SHIFT+W for window and CTRL+ALT+W for session be suitable?

@louislva louislva mentioned this issue Sep 2, 2017
Merged
@chabou chabou added the 💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ label Sep 2, 2017
@chabou chabou mentioned this issue Sep 2, 2017
Closed
2 tasks
@chabou chabou closed this as completed in 843ebd2 Sep 3, 2017
@chabou
Copy link
Contributor

chabou commented Sep 7, 2017

ctrl+altis not a suitable modifier. See #2179 (comment)
We should find another shortcut

@chabou chabou reopened this Sep 7, 2017
@chabou chabou mentioned this issue Sep 7, 2017
Closed
2 tasks
@peterdanis
Copy link

I suggest:
"window:close": "ctrl+shift+q" (q as quit)
"pane:close": "ctrl+shift+w"

h93xV2 added a commit to h93xV2/hyper that referenced this issue Sep 7, 2017
@h93xV2
Remove keymap conflict on Windows
4fd1731 
In response to issue vercel#2156, the conflict between window close and pane close is resolved by mapping them to ctrl+shift+q and ctrl+shift+w, respectively.
h93xV2 added a commit to h93xV2/hyper that referenced this issue Sep 7, 2017
@h93xV2
Remove keymap conflict for Windows.
83ba757 
In response to issue vercel#2156, the keymapping conflict has been removed from app/win32.json. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.
@h93xV2 h93xV2 mentioned this issue Sep 7, 2017
Closed
h93xV2 added a commit to h93xV2/hyper that referenced this issue Sep 7, 2017
@h93xV2
Fix for keymapping bug on Linux and Windows
ea41ade 
In response to issue vercel#2156, the keymapping conflict has been removed from linux.json and win32.json in the app/keymaps/ directory. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.
@h93xV2 h93xV2 mentioned this issue Sep 7, 2017
Merged
h93xV2 added a commit to h93xV2/hyper that referenced this issue Sep 8, 2017
@h93xV2
Fix for keymapping bug on Linux and Windows
3a92c00 
In response to issue vercel#2156, the keymapping conflict has been removed from linux.json and win32.json in the app/keymaps/ directory. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.
albinekb pushed a commit that referenced this issue Sep 11, 2017
@h93xV2 @albinekb
Fix for keymapping bug on Linux and Windows (#2189)
3bca7c2 
* Fix for keymapping bug on Linux and Windows

In response to issue #2156, the keymapping conflict has been removed from linux.json and win32.json in the app/keymaps/ directory. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.

* Fix for failed test on initial commit.
@leo leo closed this as completed Sep 13, 2017
spncrgr pushed a commit to spncrgr/hyper that referenced this issue Sep 23, 2017
@h93xV2 @spncrgr
Fix for keymapping bug on Linux and Windows (vercel#2189)
438cbc6 
* Fix for keymapping bug on Linux and Windows

In response to issue vercel#2156, the keymapping conflict has been removed from linux.json and win32.json in the app/keymaps/ directory. Now the keymap for window close is ctrl+shift+q and the keymap for pane close is ctrl+shift+w.

* Fix for failed test on initial commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 Feedback Wanted Issue or PR needs input from the community! Lend your thoughts ✨ good first issue Issue is good for Hyper newcomers 🐧 Platform: Linux Issue pertains to Linux 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chabou @leo @louislva @MarkDaviesEsendex @peterdanis