Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup/working directory config #3000

Closed
chabou opened this issue May 10, 2018 · 11 comments
Closed

Add startup/working directory config #3000

chabou opened this issue May 10, 2018 · 11 comments
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper

Comments

@chabou
Copy link
Contributor

chabou commented May 10, 2018

It should be more easy to configure a startup directory.
Currently, it has to be done at shell level for macOS/Linux shells (.bashrc/.zshrc...) and at hyper config level for CMD/PowerShell (See #2794).

I suggest to add an optional workingDirectory config parameter. If it is empty/undefined/malformated, default (config location) directory will be used.
Only an absolute path is valid. If a path is passed as parameter to hyper, it must be used instead of config/default, as is currently the case.

Magic should occur here: https://github.com/zeit/hyper/blob/f72093c9d75da963544a48a0eee8107ecb170cf8/app/ui/window.js#L93

@chabou chabou added help wanted Contributions wanted towards the issue 🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper good first issue Issue is good for Hyper newcomers labels May 10, 2018
@mtslzr
Copy link

mtslzr commented May 16, 2018

Created PR #3021 for this.

@DamianRivas
Copy link

@chabou perhaps this issue should be closed since it was resolved by commit 164a600

I was looking for a good issue to work on. I need to make 10 PRs to OSS projects before I can graduate from my apprenticeship. I use Hyper daily so I would love to help with anything if y'all need it :)

@corbanb
Copy link

corbanb commented May 13, 2019

Does this no longer work in 3.0?

workingDirectory: "~/Sites/someplace",

For now I just added cd ~/Sites/someplace to one of my custom plugin files foroh-my-zsh. ha

@kaushikchaubal
Copy link
Contributor

I just added the workingDirectory field in my .hyper.js file as well and it didn't work as expected.

I aim to create a PR with a fix soon.

kaushikchaubal added a commit to kaushikchaubal/hyper that referenced this issue Jul 26, 2019
kaushikchaubal added a commit to kaushikchaubal/hyper that referenced this issue Jul 26, 2019
kaushikchaubal added a commit to kaushikchaubal/hyper that referenced this issue Jul 26, 2019
@kaushikchaubal
Copy link
Contributor

PR created for this: #3769

Ready for review

@chabou
Copy link
Contributor Author

chabou commented Jul 30, 2019

There is a plugin for this: https://www.npmjs.com/package/hyper-working-directory

But maybe it should be a core feature?

@kaushikchaubal
Copy link
Contributor

My two cents... this was a core feature which then broke. I think if we want to keep like-fo-like, it should be a core feature. (happy to be overruled)

@chabou
Copy link
Contributor Author

chabou commented Aug 2, 2019

I think it was never implemented 🤔

@ppot
Copy link
Contributor

ppot commented Aug 3, 2019

Was never a core feature. But had a flag in the config to define a default for the user.

Stanzilla pushed a commit that referenced this issue Oct 4, 2019
* #3000: Adding logic to support working directory config

* #3000: Removing unused import

* #3000: Removing extra space
@jletey
Copy link

jletey commented Nov 11, 2019

Has this been implemented? I see that #3769 was merged, but see #3769 (comment)

@LabhanshAgrawal
Copy link
Collaborator

#3769 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue is good for Hyper newcomers help wanted Contributions wanted towards the issue 🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper
Projects
None yet
Development

No branches or pull requests

8 participants