-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startup/working directory config #3000
Comments
Created PR #3021 for this. |
Does this no longer work in 3.0?
For now I just added |
I just added the workingDirectory field in my .hyper.js file as well and it didn't work as expected. I aim to create a PR with a fix soon. |
PR created for this: #3769 Ready for review |
There is a plugin for this: https://www.npmjs.com/package/hyper-working-directory But maybe it should be a core feature? |
My two cents... this was a core feature which then broke. I think if we want to keep like-fo-like, it should be a core feature. (happy to be overruled) |
I think it was never implemented 🤔 |
Was never a core feature. But had a flag in the config to define a default for the user. |
Has this been implemented? I see that #3769 was merged, but see #3769 (comment) |
#3769 was merged |
It should be more easy to configure a startup directory.
Currently, it has to be done at shell level for macOS/Linux shells (.bashrc/.zshrc...) and at
hyper
config level for CMD/PowerShell (See #2794).I suggest to add an optional
workingDirectory
config parameter. If it is empty/undefined/malformated, default (config location) directory will be used.Only an absolute path is valid. If a path is passed as parameter to
hyper
, it must be used instead of config/default, as is currently the case.Magic should occur here: https://github.com/zeit/hyper/blob/f72093c9d75da963544a48a0eee8107ecb170cf8/app/ui/window.js#L93
The text was updated successfully, but these errors were encountered: