Fix keyboard shortcuts on Linux and Windows #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheuss
added
🐧 Platform: Linux
This was referenced Nov 30, 2016
|
Works! |
matheuss
added a commit
that referenced
this pull request
Dec 2, 2016
Such regression broke the character composition/paste on macOS
|
When will it be in a release? It's a key feature. >.> |
|
@roccomuso Comes with the next release |
Closed
|
still not working with archlinux-kde |
|
was this added to 1.0? is not working in my xubuntu 16.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a temporary fix for the issue with keyboard shortcuts (accelerators) on Windows and Linux.
The fix consists of a check on every
keyDownevent: if such event is a Hyper accelerator (Ctrl+tab, for example), we preventhtermfrom consuming it. With that, our code (or Electron's code, depending on the accelerator) can consume it.This is a temporary fix because in the near future we'll probably have a way to customize the accelerators via
.hyper.js.Closes #274; Closes #1025;