[Windows] Add right click copy/paste

[Specro]

Adds the usual Windows behavior of copying or pasting when right clicking in the terminal. Would be nice if more people would test that this works correctly 😄 Besides that it's ready to be merged.

Closes #1019

[kleinfreund]

Would this lead to copying with rightclick on Windows by default?

That said, is there a main issue regarding cross-platform default keybindings? The various ways different operating system and terminal programs use shortcuts is an incredible mess. Copying via Mouse 2 (rightclick)? Or even ShiftIns? Or CtrlShiftC? Or only CtrlC? I'm sure there are even more ways.

In general, should the Hyper keybindings match the OS default? In this case, at this point I would argue that the default on Windows is CtrlC.

[albinekb]

I would like this to be an opt-in-option. It's weird for users if Hyper acts different on based on OS...

Also you paste on right-click, what if you want to use the context-menu? 🤔

Any thoughts? As I don't use windows I'm not 100% sure 👼

[Specro]

@kleinfreund It seems Windows cmd has a QuickEdit mode which if enabled, lets the user select text in the window and copy/paste it on right click. Without it enabled, on right click a context menu is shown and then cmd actually considers Enter the default key for copying.

So one more key to that mess you mentioned 😕

I think we should go with @albinekb idea of making an option for this.

[ppot]

Appart form this. This type of action should be handled by hterm directly in the onMouseDown_

[anaisbetts]

Windows Person here, let me answer a few questions for the macOS folx:

Would this lead to copying with rightclick on Windows by default?

If there is a selection, right-click == Copy and clear selection, if not, right-click == Paste

In general, should the Hyper keybindings match the OS default? In this case, at this point I would argue that the default on Windows is CtrlC.

Not in a terminal, because of the obvious conflict between Ctrl-C as SIGINT. The old-school DOS shortcut Shift-Insert applies here.

QuickEdit is a deeply Windows Thing but should indeed be an option in Hyper if it wants to be a terminal on Windows (tbh, if you got used to it on macOS or Linux, I bet you'd get value out of it there too tho). I suspect it should be opt-in though on non-Windows.

As a Windows user, trying to use a terminal without Quickedit is like trying to use a terminal one-handed :)

Also you paste on right-click, what if you want to use the context-menu? 🤔

When QuickEdit is enabled, there is no context-menu

[Specro]

@paulcbetts Very well explained 👌
@ppot Is this ok? 🤔

I named the config option quick edit for now. If anyone has any better suggestions they're welcome to share 😄

[anaisbetts]

I would like this to be an opt-in-option. It's weird for users if Hyper acts different on based on OS...

I think that this should be enabled by default on Windows, since it is also enabled by default in the default terminal on Win10

[matheuss]

Thanks @Specro 🙌