CLI: use .hyper.js from repo root dir when running in dev mode #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this first contribution 🙏 But some part must be modified: We don't need a new config file. We need to have exactly same behavior with CLI than with Hyper. If it is in dev mode, it checks the existence of config file |
chabou
suggested changes
Mar 28, 2018
|
oops... sorry about that 👼 ..please see latest commit |
tool3
changed the title
chabou
suggested changes
Mar 28, 2018
cli/api.js
Outdated
| @@ -5,7 +5,12 @@ const registryUrl = require('registry-url')(); | |||
| const pify = require('pify'); | |||
| const recast = require('recast'); | |||
|
|
|||
| const fileName = `${os.homedir()}/.hyper.js`; | |||
| const devConfigFileName = '../.hyper.js'; | |||
There was a problem hiding this comment.
You need to resolve this path with something like __dirname. It should not be impacted by the current working directory.
|
Used |
chabou
changed the title
chabou
approved these changes
Apr 20, 2018
chabou
pushed a commit
that referenced
this pull request
Dec 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be merged automatically.
I went with process.env.NODE_ENV because it is set automatically to 'production' when running in..well..production.
Thank you so much ! if I missed anything be sure to let me know please :)
1st contribution!