Upgrade Electron to v4

[juancampa]

Supersedes #3325

Talked to @rauchg and we think it's better to skip v3 altogether, go straight for v4, and use the canary channel to test it.

Sanity checks:

• No errors on output
• Plugins work (tested installing and using https://github.com/nyx-team/hyper-nyx)
• Multiple tabs
• Multiple windows
• Splits
• Menus
• Auto update (pop up shows)
• Clean shutdown
• Vim session with splits
• Clipboard works
  • Through menu
  • Hotkeys (broken but I added a work-around for now)
• Initial zoom is the same as canary and pinch remains disabled
• Performance is at least on par with electron v1
  • Throughput (2% slowdown, possibly due to different zoom levels)
  • Refresh rate
• Sanity macOS
• Sanity Windows
• Went through all listed breaking changes

[chabou]

We have a problem with titlebar:

Transparent on top of Hyper

---

UPDATE: fixed 7fce112

[juancampa]

Hmm ok, seems like given that v3 worked fine but v4-beta has issues on Mac (and maybe windows?), it might be better to go with v3 for now as opposed to writing temporary work-arounds, since they might get fixed by the electron team eventually.

@rauchg, @chabou, thoughts on this?

[Stanzilla]

4.0 is final as of today https://github.com/electron/electron/releases/tag/v4.0.0

[Stanzilla]

That looks like electron-rebuild needs an update for electron v4 @MarshallOfSound

[juancampa]

That looks like electron-rebuild needs an update for electron v4 @MarshallOfSound

@Stanzilla, It works now with the new node-abi https://github.com/lgeiger/node-abi/releases/tag/v2.5.1

[Stanzilla]

ah, great, yarn was a bit annoying back in the day and would not upgrade that without electron-rebuild using it.

[juancampa]

ah, great, yarn was a bit annoying back in the day and would not upgrade that without electron-rebuild using it.

Yeah, I struggled with that too. The trick is to delete node-abi from yarn.lock and have yarn figure out what the latest version is again.

Here's the yarn issue: yarnpkg/yarn#4986

was fixed

[Stanzilla]

node version has to be updated for AppVeyor and CircleCI as well

[juancampa]

node version has to be updated for AppVeyor and CircleCI as well

@Stanzilla, not sure what you mean here. Is there anything else other than these two lines?

https://github.com/zeit/hyper/pull/3329/files#diff-354f30a63fb0907d4ad57269548329e3R9
https://github.com/zeit/hyper/pull/3329/files#diff-180360612c6b8c4ed830919bbb4dd459R13

Following this table:

https://github.com/electron/node#branching-strategy

[Stanzilla]

@juancampa nope that's fine, I just did not see the appveyor change in your PR. For Circle, I don't know how they specify node versions, I did not set up that CI.

[juancampa]

@juancampa nope that's fine, I just did not see the appveyor change in your PR. For Circle, I don't know how they specify node versions, I did not set up that CI.

Looks like it's passing, so I'm not gonna worry about it for now

Seems to be passing

[juancampa]

@Stanzilla, did you by any chance tested this branch on windows? I'm looking for someone to help me there, since I don't have a windows machine. A quick sanity check would be super helpful

[Stanzilla]

Sure thing! It looks like you forgot to address https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#appmakesingleinstance and it errors because of it.

[juancampa]

@Stanzilla sorry for the delay, I just had to back-merge canary. We reverted the commit that introduced that call. Feel free to test again when you get a few.

[Stanzilla]

https://i.imgur.com/DH6D9I1.png

that should be https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#menu

Try looking at my initial electron v2 PR to see if you have all those changes covered #2967

[juancampa]

@Stanzilla weird, I'm pretty sure I had that, since I did test the menus. I must have missed it in a rebase or merge. Should be good now

[Stanzilla]

Does the config have a new location? it ignores what I do in ~/.hyper.js

[juancampa]

Does the config have a new location? it ignores what I do in ~/.hyper.js

It doesn't. Seems to work fine on Linux and MacOS (I just changed the font size)

[Stanzilla]

font size works, shell does not,

[juancampa]

Yeah, I'm seeing it too, but it doesn't seem to work on the canary branch either so it must be something else

[Stanzilla]

QA's been on a long vacation :D

[juancampa]

@Stanzilla, Ok, I just looked into it and it was introduced by my optimistic session creation PR. Working on a fix

[Stanzilla]

Sounds great!

[juancampa]

Here's the fix on the shell issue: #3367. @Stanzilla let me know if everything worked fine on Windows so we can move forward with this PR

[Stanzilla]

well that was a quick and unexpected merge, but I can confirm that it works as expected now.

[juancampa]

Optimistic merge