Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for selected text color setting #3655

Closed
wants to merge 2 commits into from
Closed

Add config option for selected text color setting #3655

wants to merge 2 commits into from

Conversation

Luxcium
Copy link

@Luxcium Luxcium commented May 10, 2019

as per: Add a config option for selected text colour setting #2934

Not really useful you may think, I have put a "commented out" reminder within a TODO memo, to remember to do it I will try to change it myself but until then it could stay there as a reminder

  • To help whoever reviews this PR, it'd be extremely helpful to list whether this PR is ready to be merged:
    it is only a commented TODO, for now at least, so it is ready to be merged indeed

  • If your PR changes some API, please make a PR for hyper website too: https://github.com/zeit/hyper-site.
    If I can change it myself without breaking everything I will add the option in the list on the web site.

@Luxcium
Copy link
Author

Luxcium commented May 11, 2019

I am inside 'xterm.js/src/renderer/Types.ts' and it seems that there is no foreground colour for a selection:

export interface IColorSet {
    foreground: IColor;
     background: IColor;
    cursor: IColor;
    cursorAccent: IColor;
    selection: IColor;
    ansi: IColor[];
}

@Luxcium
Copy link
Author

Luxcium commented May 11, 2019

This issue must be resolved at the xtermjs/xterm.js level instead

@Luxcium Luxcium closed this May 11, 2019
@Luxcium Luxcium deleted the luxcium/selectionText branch May 11, 2019 17:10
@blakeperdue
Copy link

@Luxcium this was added to xterm.js in xtermjs/xterm.js#3813 , can we now add a config option (like selectionForeground) to Hyper to allow this color to be configured?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants