Add config option for selected text color setting #3655
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per: Add a config option for selected text colour setting #2934
Not really useful you may think, I have put a "commented out" reminder within a
TODO
memo, to remember to do it I will try to change it myself but until then it could stay there as a reminderTo help whoever reviews this PR, it'd be extremely helpful to list whether this PR is ready to be merged:
it is only a commented TODO, for now at least, so it is ready to be merged indeed
If your PR changes some API, please make a PR for hyper website too: https://github.com/zeit/hyper-site.
If I can change it myself without breaking everything I will add the option in the list on the web site.