Removed optimistic session initialization #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Nice, thank you! |
|
i like code removal 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3770
This small PR removes the optimistic session creation (the
createInitialSession()call in line 160 ofapp/ui/window.js), which causes a bug initialization parameters do not take effect unless the user manually executes a full reload (#3770) e.g. the hypercwd plugin's initialWorkingDirectory config option has no effect until a full reload is run.After some digging, I've found that this optimistic session creation added for a modest startup time improvement in #3352, so I reckon there will not be an unacceptable increase in startup time for any supported platform.
I figure this PR is ready to merge. Manual testing suggest that these slight changes fix the problem without a noticeable difference in startup time or performance in general.