-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for displaying Sixels #6987
Conversation
Thanks for your contribution, I'll test it out soon. |
The add-on claims compatibility with xterm.js 5.1.0, which is the current stable release, but I tried it out with 5.2.0 beta and it still works there. I am open to a plug-in solution, if adding an xterm add-on is supported by one of Hyper’s extension APIs (I am not too familiar with those, but will have a look later). If not, we could also add a boolean variable to the configuration JSON for enabling/disabling the add-on. |
Oh, I saw jerch/xterm-addon-image#38 , didn't know it's fixed. |
If a plug-in solution is favored, xterm.js’ |
@marvinruder and @LabhanshAgrawal thanks for your efforts on this. Really looking forward to this feature :) |
Ah sorry, forgot to close the issue along with the fix. |
Minor headsup - just added iTerm IIP support in the addon, though I consider it alpha (cannot really test&compare against iTerm2). |
Sorry, I was caught up with things, have to rethink the pr on xterm's repo for ligature fix as well, I'm thinking to merge this (with xterm v5) in the coming days, even if the ligature fix is not there yet, as anyways ligatures are disabled on electron in xterm v5 currently, so we can have few canary releases without ligatures, and then work on that instead of blocking this. |
I've upgraded xterm to v5, please rebase. |
Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
great work @marvinruder, also thanks @jerch for the awesome addon and your support on this pr. |
Hi there, |
Closes #6748
For a quick demo, run
curl https://raw.githubusercontent.com/saitoha/libsixel/master/images/snake.six