Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💯 test coverage #190

Merged
merged 1 commit into from
Mar 16, 2017
Merged

💯 test coverage #190

merged 1 commit into from
Mar 16, 2017

Conversation

floatdrop
Copy link
Contributor

@floatdrop floatdrop commented Mar 16, 2017 •
edited
Loading

Some places can be better. For example testing for call to console.error is quite dirty. May be logging should be improved?

P.s. still 87.18% for branches.

@floatdrop floatdrop changed the title 💯 test coverage 💯 test coverage Mar 16, 2017
@floatdrop floatdrop force-pushed the 100-percent-coverage branch 3 times, most recently from 57c7d66 to 8ce6aa6 Compare March 16, 2017 13:55
timneutkens
timneutkens approved these changes Mar 16, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timneutkens timneutkens merged commit a7f1d43 into vercel:master Mar 16, 2017
@floatdrop floatdrop deleted the 100-percent-coverage branch March 16, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floatdrop @timneutkens