Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use text/plain as default content-type in .json #208

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Use text/plain as default content-type in .json #208

merged 1 commit into from
Mar 27, 2017

Conversation

floatdrop
Copy link
Contributor

@floatdrop floatdrop commented Mar 27, 2017 •
edited
Loading

Otherwise media-typer throws an error:

TypeError: argument string is required
    at Object.parse (/Users/floatdrop/github.com/micro/examples/json-body-parsing/node_modules/media-typer/index.js:141:11)
    at Promise.resolve.then (/Users/floatdrop/github.com/micro/examples/json-body-parsing/node_modules/micro/lib/server.js:52:26)

@coveralls
Copy link

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c4ffed8 on floatdrop:content-type-should-be-a-string into 8012c9e on zeit:master.

@floatdrop floatdrop force-pushed the content-type-should-be-a-string branch 2 times, most recently from 96d3249 to 200c30c Compare March 27, 2017 07:01
@coveralls
Copy link

coveralls commented Mar 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 200c30c on floatdrop:content-type-should-be-a-string into 8012c9e on zeit:master.

@floatdrop floatdrop force-pushed the content-type-should-be-a-string branch from 200c30c to 00a4b1f Compare March 27, 2017 09:18
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00a4b1f on floatdrop:content-type-should-be-a-string into 8012c9e on zeit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00a4b1f on floatdrop:content-type-should-be-a-string into 8012c9e on zeit:master.

@floatdrop floatdrop mentioned this pull request Mar 27, 2017
Closed
@leo leo merged commit c4d6b45 into vercel:master Mar 27, 2017
This was referenced Mar 27, 2017
Closed
Closed
@floatdrop floatdrop deleted the content-type-should-be-a-string branch March 27, 2017 15:43
chiefjester added a commit to chiefjester/urlencoded-body-parser that referenced this pull request Mar 27, 2017
@chiefjester
Add fallback for encoding
2f11064 
- encoding fallbacks to `UTF-8`
- getting TypeError in media typer when content type is missing
- related to vercel/micro#208
@chiefjester chiefjester mentioned this pull request Mar 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floatdrop @coveralls @leo