Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw an error if the val is invalid #52

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Conversation

adoyle-h
Copy link
Contributor

Give an error response to developers immediately, when calling ms(null) or ms(undefined) or other invalid things.
It can help developers avoid mistakes, and less debug.

@leo leo added the minor label Sep 3, 2016
@leo
Copy link
Contributor

leo commented Sep 3, 2016

Please rebase with master! 😊

@adoyle-h
Copy link
Contributor Author

adoyle-h commented Sep 4, 2016

@leo I have installed the 71616a6 version. It still dose not work.

monosnap 2016-09-04 08-58-23

monosnap 2016-09-04 08-58-44

@leo
Copy link
Contributor

leo commented Sep 4, 2016

If you're not familiar with how this works: It basically means that you're syncing the branch on which you've added the changes (within our fork of this repo) with the master branch of this repo.

This technique ensures that no conflicts will occur once we decide to merge the PR.

- give an error response to developers immediately, when calling `ms(null)` or `ms(undefined)` or other invalid things.
- to help developers avoid mistakes, and less debug.
@adoyle-h
Copy link
Contributor Author

adoyle-h commented Sep 4, 2016

Sorry, I misread your words. Now it could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants