Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use 'import.meta' outside a module on 0.36.0 (not 0.34.0) #1019

Open
frbuceta opened this issue Dec 16, 2022 · 4 comments · May be fixed by #1236
Open

Cannot use 'import.meta' outside a module on 0.36.0 (not 0.34.0) #1019

frbuceta opened this issue Dec 16, 2022 · 4 comments · May be fixed by #1236
Labels
bug Something isn't working

Comments

@frbuceta
Copy link

I just updated from version 0.34.0 to 0.36.0. In version 0.34.0 it works perfectly.

ncc: Version 0.36.0
ncc: Compiling file index.js into CJS
...
esm_dirname = (0,external_url_.fileURLToPath)(import.meta.url);
                                                       ^^^^

SyntaxError: Cannot use 'import.meta' outside a module
...
@imyelo
Copy link

imyelo commented Mar 10, 2023

source:

import { fileURLToPath } from "url"

fileURLToPath(`${import.meta.url}/../somestaticfile.txt`)

compile with 0.34.0:

import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module";
/******/ /* webpack/runtime/compat */
/******/ 
/******/ if (typeof __nccwpck_require__ !== 'undefined') __nccwpck_require__.ab = new URL('.', import.meta.url).pathname.slice(import.meta.url.match(/^file:\/\/\/\w:/) ? 1 : 0, -1) + "/";
/******/ 
/************************************************************************/
var __webpack_exports__ = {};

;// CONCATENATED MODULE: external "url"
const external_url_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("url");
;// CONCATENATED MODULE: ./src/index.js


(0,external_url_namespaceObject.fileURLToPath)(`${"file:///project/home/imyelo/workspace/src/index.js"}/../somestaticfile.txt`);

compile with 0.36.0:

import { createRequire as __WEBPACK_EXTERNAL_createRequire } from "module";
/******/ /* webpack/runtime/compat */
/******/ 
/******/ if (typeof __nccwpck_require__ !== 'undefined') __nccwpck_require__.ab = new URL('.', import.meta.url).pathname.slice(import.meta.url.match(/^file:\/\/\/\w:/) ? 1 : 0, -1) + "/";
/******/ 
/************************************************************************/
var __webpack_exports__ = {};

;// CONCATENATED MODULE: external "url"
const external_url_namespaceObject = __WEBPACK_EXTERNAL_createRequire(import.meta.url)("url");
;// CONCATENATED MODULE: ./src/index.js


(0,external_url_namespaceObject.fileURLToPath)(`${import.meta.url}/../somestaticfile.txt`);

seems like webpack doesn't convert import.meta.url staticly in ncc ^0.36.0

reproduces in https://codesandbox.io/p/sandbox/funny-rain-y4qvps

@styfle styfle added the bug Something isn't working label Mar 10, 2023
@schowdhuri
Copy link

Thanks for this! I had to downgrade all the way from 0.38 to make this work 🤷🏽‍♂️

@phisch
Copy link

phisch commented Mar 22, 2024

I just ran into the same issue, and downgrading to 0.34.0 worked for me as well.
What a coincidence that we run into the same issue just 8 hours apart, when it's been inactive for a year!

@meienberger
Copy link

Has there been a workaround found for this issue? I managed to pinpoint the problematic import.meta.url inside one of my dependencies. Removing it solves the issue but also downgrading to 0.34.0 solves it. Is it possibly this change which is causing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants