-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable compile time evaluation of import.meta.url #897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Can you add a test to ensure this behavior is working as intended?
I added a unit test to validate that I think some test fixtures also need to be updated due to the new webpack version? I'm happy to leave that to you though, if that's ok 😁 |
Looks like the issue is here Lines 79 to 92 in a9c07e0
The returned object no longer matches the latest webpack expected type here https://github.com/webpack/webpack/blob/d3a0f8de03f26a83b4d5db3cfe177617a3801df3/types.d.ts#L12062-L12097 |
…ated `NodeWatchFileSystem` class
@styfle Thanks for pointing me to the watcher implementation! I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks! 🎉
I'm affected by webpack/webpack#14445, fixed in webpack/webpack#15246, available in webpack >= v5.68.0, so I'd love to have an ncc version using webpack >= v5.68.0!
EDIT: Forgot to actually set the corresponding config option at first, added that in f19ab9c.