Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignore failing test on macOS + run in band test-coverage #1216

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

theoludwig
Copy link
Contributor

@theoludwig theoludwig commented Sep 17, 2024

Fix problems with CI and tests.

More context: #1213 (comment)

@theoludwig theoludwig changed the title ci: test on fork first ci: ignore failing test on macOS + run in band test-coverage Sep 17, 2024
Copy link

socket-security bot commented Sep 17, 2024

@theoludwig
Copy link
Contributor Author

To avoid issues with "GitHub CI workflows awaiting approval", I'm running CI on my fork, here: https://github.com/theoludwig/ncc/pull/1

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a life-saver, thanks! 🥇

@styfle styfle merged commit 9e7451b into vercel:main Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants