Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out one of the expensive parts of the build was this function (easy to see by just commenting out the externals and comparing build speeds).
This reimplements the same logic using some custom optimizations.
The other thing implemented here is to move the
.ts
and.tsx
checks in the resolver to the end. This does mean thattest.js
will take precedence overtest.ts
, but the benefit is that the Webpack resolver doesn't have to stat every single that is ever required in the tree as its.ts
variation first (which it was doing for EVERYTHING in node_modules...)Combined these shave about 5 seconds off a 40 second build for me.