Fixup shebang loader order #196
Conversation
|
I've also updated the Webpack fixtures here, as it seems the output module numbering has been changed by new work on the v5 branch. |
guybedford
force-pushed
the
shebang-analysis
branch
from
942becf
to
d96404a
Compare
|
This is quite odd, the unit tests were passing with the updates in the commit there, but now seem to have stopped working again. I'm not sure why the webpack output keeps changing like this perhaps @sokra has an idea? The tests are passing fine for me locally with this yarn.lock. |
src/index.js
Outdated
| @@ -139,6 +139,7 @@ module.exports = ( | |||
| }, | |||
| { | |||
| parser: { amd: false }, | |||
| test: /^(.(?!.*\.node$))*$/, | |||
There was a problem hiding this comment.
That's probably the regexp with the worst performance you could have chosen.
Try: exclude: /\.node$/
|
Ahh, the issue here was that there are two sets of unit tests - one with and without coverage. Completely forgot, despite being responsible for this :P |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 67.87% 67.87%
=======================================
Files 12 12
Lines 579 579
=======================================
Hits 393 393
Misses 186 186
Continue to review full report at Codecov.
|
This ensures that analysis can still be correctly applied alongside the shebang loader, fixing the error in #192.