Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores the permissions of assets in a side table and ensures the corresponding output asset permissions.
In theory this is a major change as the assets API is changed to be an object of
{ [assetName]: { source, permissions } }
instead of{ [assetName]: source }
now.@sokra an interesting thing here was it turned out unnecessary to maintain the cache as for some reason it seems like Webpack isn't actually caching the sources with emitted assets. Ideally these should be cached though I think?
I've left the cache persistence of asset permissions commented out for now given the above.