Output asset permissions #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 67.87% 68.68% +0.81%
==========================================
Files 12 12
Lines 579 594 +15
==========================================
+ Hits 393 408 +15
Misses 186 186
Continue to review full report at Codecov.
|
sokra
reviewed
Jan 9, 2019
| const nodeLoader = require(__dirname + "/loaders/node-loader.js"); | ||
| const relocateLoader = require(__dirname + "/loaders/relocate-loader.js"); | ||
| const nodeLoader = eval('require(__dirname + "/loaders/node-loader.js")'); | ||
| const relocateLoader = eval('require(__dirname + "/loaders/relocate-loader.js")'); |
There was a problem hiding this comment.
Why not require("./loaders/node-loader.js") and define it as external
There was a problem hiding this comment.
I just tried this and it doesn't work (get Cannot read "assets" of undefined indicating there may be separate instances in play, or something else).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores the permissions of assets in a side table and ensures the corresponding output asset permissions.
In theory this is a major change as the assets API is changed to be an object of
{ [assetName]: { source, permissions } }instead of{ [assetName]: source }now.@sokra an interesting thing here was it turned out unnecessary to maintain the cache as for some reason it seems like Webpack isn't actually caching the sources with emitted assets. Ideally these should be cached though I think?
I've left the cache persistence of asset permissions commented out for now given the above.