Fixup tests on mac including asset symlinks support #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
asset-symlinks
branch
from
283630f
to
78201dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
+ Coverage 68.37% 68.71% +0.33%
==========================================
Files 12 12
Lines 370 374 +4
==========================================
+ Hits 253 257 +4
Misses 117 117
Continue to review full report at Codecov.
|
styfle
reviewed
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the webpack-asset-relocator-loader to support the tfjs-node build that was failing on MacOS.
The failure was due to shared libraries with .so extensions not begin emitted on mac, and also due to not having support for symlinked assets, as the pathing of the shared library relies on symlinks. Both of these are fixed in the latest webpack-asset-relocator-loader release at vercel/webpack-asset-relocator-loader@23b0dbf.