Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google cloud firestore integration test #416

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Add google cloud firestore integration test #416

merged 1 commit into from
Jun 11, 2019

Conversation

guybedford
Copy link
Contributor

This adds an integration test for require('@google-cloud/firestore'), as in #412.

@guybedford guybedford requested a review from styfle as a code owner June 11, 2019 16:52
@codecov-io
Copy link

Codecov Report

Merging #416 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          13       13           
  Lines         391      391           
=======================================
  Hits          288      288           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421c19d...0a5d42b. Read the comment docs.

@styfle
Copy link
Member

styfle commented Jun 11, 2019

@guybedford So it looks like it passes without any changes. Do we just need to do a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants