Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack-asset-relocator-loader 0.5.6 #442

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Jun 25, 2019

This upgrades to the latest release at https://github.com/zeit/webpack-asset-relocator-loader/releases/tag/0.5.6.

This will fix #435 and fix #440, completing the now-node upgrade bug fixes outlined in #434.

In addition, we expose the filterAssetBase option as an ncc option - this will allow fixing the 08 asset build in now-node by setting this path to the path to the application folder being built.

@guybedford guybedford requested a review from styfle as a code owner June 25, 2019 23:04
styfle
styfle previously approved these changes Jun 25, 2019
@styfle styfle dismissed their stale review June 25, 2019 23:13

There are 3 failing tests

@codecov-io
Copy link

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files          13       13           
  Lines         395      395           
=======================================
  Hits          295      295           
  Misses        100      100
Impacted Files Coverage Δ
src/index.js 83.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5aefd...98eeb5f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom packageBase configuration Builtin TypeScript bug
3 participants