Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript builtin without workaround #447

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix TypeScript builtin without workaround #447

merged 1 commit into from
Jul 2, 2019

Conversation

guybedford
Copy link
Contributor

This provides the root fix to #445 without using the workaround.

Turns out it was as simple as the asset emission folder name changing!

@guybedford guybedford requested a review from styfle as a code owner July 2, 2019 22:04
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@codecov-io
Copy link

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files          13       13           
  Lines         395      395           
=======================================
  Hits          295      295           
  Misses        100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d928b4f...bac4c29. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants