-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license flag to create license file when running ncc #570
Conversation
@@ -206,68 +278,7 @@ module.exports = ( | |||
} | |||
] | |||
}, | |||
plugins: [ | |||
{ | |||
apply(compiler) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just moved above so we can dynamically add the LicenseWebpackPlugin
to this array based on the results of the license
flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! 🥇
Looks like the deprecation warnings were fixed in 2.3.3 |
This PR addresses #569
It adds the --license flag to use license-webpack-plugin to generate a license file alongside the ncc output to adhere to the terms of common software licenses.
Currently, there is an open issue where that plugin outputs some warnings, so the output for a run looks like
That is being tracked here and is hopefully resolved so we can minimize the output.
I did some local testing, but did not add any unit tests, let me know if there's some testing that would be worthwhile to add, and if you could provide some guidance on how to do so, I wasn't able to find a
contributing.md
or documentation.