Skip to content

Commit

Permalink
Turbopack: reenable some skipped test cases (#57177)
Browse files Browse the repository at this point in the history
### What?

### Why?

better CI coverage

### How?



Closes WEB-1820
  • Loading branch information
sokra authored Oct 21, 2023
1 parent 488a61f commit 31dddca
Showing 1 changed file with 15 additions and 10 deletions.
25 changes: 15 additions & 10 deletions test/build-turbopack-tests-manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@ const SKIPPED_TEST_SUITES = {
'test/integration/app-document-remove-hmr/test/index.test.js': [
'_app removal HMR should HMR when _document is removed',
],
'test/integration/create-next-app/package-manager.test.ts': [
'should use pnpm as the package manager on supplying --use-pnpm',
'should use pnpm as the package manager on supplying --use-pnpm with example',
'should infer pnpm as the package manager',
'should infer pnpm as the package manager with example',
],
'test/integration/css/test/css-modules.test.js': [
'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from other)',
'CSS Modules Composes Ordering Development Mode should have correct color on index page (on nav from index)',
Expand All @@ -80,10 +74,6 @@ const SKIPPED_TEST_SUITES = {
'test/integration/import-assertion/test/index.test.js': [
/should handle json assertions/,
],
'test/integration/trailing-slashes/test/index.test.js': [
'Trailing slashes dev mode, with basepath, trailingSlash: true /docs/linker?href=/ should navigate to /docs/',
'Trailing slashes dev mode, with basepath, trailingSlash: true /docs/linker?href=/ should push route to /docs/',
],
'test/integration/env-config/test/index.test.js': [
'Env Config dev mode with hot reload should provide env for SSG',
'Env Config dev mode with hot reload should provide env correctly for SSR',
Expand Down Expand Up @@ -116,6 +106,8 @@ async function updatePassingTests() {
})
const skips = SKIPPED_TEST_SUITES[filepath] ?? []

const skippedPassingNames = []

let initializationFailed = false
for (const testCase of testResult.assertionResults) {
let { fullName, status } = testCase
Expand All @@ -129,6 +121,7 @@ async function updatePassingTests() {
status = 'failed'
}
if (shouldSkip(fullName, skips)) {
if (status === 'passed') skippedPassingNames.push(fullName)
status = 'flakey'
}

Expand All @@ -138,6 +131,18 @@ async function updatePassingTests() {
}
statusArray.push(fullName)
}

if (skippedPassingNames.length > 0) {
console.log(
`${filepath} has ${
skippedPassingNames.length
} passing tests that are marked as skipped: ${JSON.stringify(
skippedPassingNames,
0,
2
)}`
)
}
}
}

Expand Down

0 comments on commit 31dddca

Please sign in to comment.