Skip to content

Commit

Permalink
Stop testing react-dom/server in RSCs (#69139)
Browse files Browse the repository at this point in the history
  • Loading branch information
eps1lon authored Aug 22, 2024
1 parent 49ef978 commit 55ff46b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
4 changes: 0 additions & 4 deletions test/e2e/app-dir/rsc-basic/app/app-react/page.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
import React from 'react'
import ReactDOM from 'react-dom'
import ReactDOMServer from 'react-dom/server.edge'
import ClientReact from './client-react'

export default function Page() {
return (
<div>
<p id="react">{'React.version=' + React.version}</p>
<p id="react-dom">{'ReactDOM.version=' + ReactDOM.version}</p>
<p id="react-dom-server">
{'ReactDOMServer.version=' + ReactDOMServer.version}
</p>
<ClientReact />
</div>
)
Expand Down
16 changes: 0 additions & 16 deletions test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -545,29 +545,25 @@ describe('app dir - rsc basics', () => {
const [
ssrReact,
ssrReactDOM,
ssrReactDOMServer,
ssrClientReact,
ssrClientReactDOM,
ssrClientReactDOMServer,
] = [
resPages$('#react').text(),
resPages$('#react-dom').text(),
resPages$('#react-dom-server').text(),
resPages$('#client-react').text(),
resPages$('#client-react-dom').text(),
resPages$('#client-react-dom-server').text(),
]
expect({
ssrReact,
ssrReactDOM,
ssrReactDOMServer,
ssrClientReact,
ssrClientReactDOM,
ssrClientReactDOMServer,
}).toEqual({
ssrReact: expect.stringMatching(bundledReactVersionPattern),
ssrReactDOM: expect.stringMatching(bundledReactVersionPattern),
ssrReactDOMServer: expect.stringMatching(bundledReactVersionPattern),
ssrClientReact: expect.stringMatching(bundledReactVersionPattern),
ssrClientReactDOM: expect.stringMatching(bundledReactVersionPattern),
ssrClientReactDOMServer: expect.stringMatching(
Expand All @@ -579,15 +575,13 @@ describe('app dir - rsc basics', () => {
const [
browserReact,
browserReactDOM,
browserReactDOMServer,
browserClientReact,
browserClientReactDOM,
browserClientReactDOMServer,
] = await browser.eval(`
[
document.querySelector('#react').innerText,
document.querySelector('#react-dom').innerText,
document.querySelector('#react-dom-server').innerText,
document.querySelector('#client-react').innerText,
document.querySelector('#client-react-dom').innerText,
document.querySelector('#client-react-dom-server').innerText,
Expand All @@ -596,14 +590,12 @@ describe('app dir - rsc basics', () => {
expect({
browserReact,
browserReactDOM,
browserReactDOMServer,
browserClientReact,
browserClientReactDOM,
browserClientReactDOMServer,
}).toEqual({
browserReact: expect.stringMatching(bundledReactVersionPattern),
browserReactDOM: expect.stringMatching(bundledReactVersionPattern),
browserReactDOMServer: expect.stringMatching(bundledReactVersionPattern),
browserClientReact: expect.stringMatching(bundledReactVersionPattern),
browserClientReactDOM: expect.stringMatching(bundledReactVersionPattern),
browserClientReactDOMServer: expect.stringMatching(
Expand Down Expand Up @@ -701,29 +693,25 @@ describe('app dir - rsc basics', () => {
const [
ssrReact,
ssrReactDOM,
ssrReactDOMServer,
ssrClientReact,
ssrClientReactDOM,
ssrClientReactDOMServer,
] = [
resPages$('#react').text(),
resPages$('#react-dom').text(),
resPages$('#react-dom-server').text(),
resPages$('#client-react').text(),
resPages$('#client-react-dom').text(),
resPages$('#client-react-dom-server').text(),
]
expect({
ssrReact,
ssrReactDOM,
ssrReactDOMServer,
ssrClientReact,
ssrClientReactDOM,
ssrClientReactDOMServer,
}).toEqual({
ssrReact: expect.stringMatching('-experimental-'),
ssrReactDOM: expect.stringMatching('-experimental-'),
ssrReactDOMServer: expect.stringMatching('-experimental-'),
ssrClientReact: expect.stringMatching('-experimental-'),
ssrClientReactDOM: expect.stringMatching('-experimental-'),
ssrClientReactDOMServer: expect.stringMatching('-experimental-'),
Expand All @@ -733,15 +721,13 @@ describe('app dir - rsc basics', () => {
const [
browserReact,
browserReactDOM,
browserReactDOMServer,
browserClientReact,
browserClientReactDOM,
browserClientReactDOMServer,
] = await browser.eval(`
[
document.querySelector('#react').innerText,
document.querySelector('#react-dom').innerText,
document.querySelector('#react-dom-server').innerText,
document.querySelector('#client-react').innerText,
document.querySelector('#client-react-dom').innerText,
document.querySelector('#client-react-dom-server').innerText,
Expand All @@ -750,14 +736,12 @@ describe('app dir - rsc basics', () => {
expect({
browserReact,
browserReactDOM,
browserReactDOMServer,
browserClientReact,
browserClientReactDOM,
browserClientReactDOMServer,
}).toEqual({
browserReact: expect.stringMatching('-experimental-'),
browserReactDOM: expect.stringMatching('-experimental-'),
browserReactDOMServer: expect.stringMatching('-experimental-'),
browserClientReact: expect.stringMatching('-experimental-'),
browserClientReactDOM: expect.stringMatching('-experimental-'),
browserClientReactDOMServer:
Expand Down

0 comments on commit 55ff46b

Please sign in to comment.