-
Notifications
You must be signed in to change notification settings - Fork 27k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hi! In previous versions (13.4.2 and earlier) in the custom server I could do the following: ``` const parsedUrl = parse(req.url, true); const { pathname } = parsedUrl; if (pathname === '/c') { await handle(req, res, parse('/b', true)); } else { await handle(req, res, parsedUrl); } ``` Of course, you can replace `handle` with `app.render` in the attached example, but in practice it is convenient to put the definition of `parsedUrl` into middleware and substitute the necessary `parsedUrl` in exceptional situations. This was broken in #49805. I'm not sure if this use of request handler is expected, but it has always worked and people have used it (probably due to lack of documentation about the difference between `app.render` and `app.getRequestHandler()`). So the change looks breaking, and I don't think it should appear in minor versions. --------- Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
- Loading branch information
1 parent
ff5338c
commit 629c9db
Showing
3 changed files
with
30 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters