Skip to content

Commit

Permalink
Turbopack build: Skip webpack specific test (#69875)
Browse files Browse the repository at this point in the history
`__non_webpack_require__` is not supported in Turbopack (webpack
specific)

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
  • Loading branch information
timneutkens authored Sep 9, 2024
1 parent 29454f0 commit 6964e22
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
18 changes: 11 additions & 7 deletions test/integration/gsp-build-errors/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ describe('GSP build errors', () => {
'production mode',
() => {
afterEach(() => fs.remove(pagesDir))

it('should fail build from module not found', async () => {
await writePage(`
;(process.env.TURBOPACK ? it.skip : it)(
'should fail build from module not found',
async () => {
await writePage(`
__non_webpack_require__('a-cool-module')
export function getStaticProps() {
Expand All @@ -32,10 +33,13 @@ describe('GSP build errors', () => {
return null
}
`)
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
expect(code).toBe(1)
expect(stderr).toContain('a-cool-module')
})
const { stderr, code } = await nextBuild(appDir, [], { stderr: true })
// eslint-disable-next-line jest/no-standalone-expect
expect(code).toBe(1)
// eslint-disable-next-line jest/no-standalone-expect
expect(stderr).toContain('a-cool-module')
}
)

it('should fail build from ENOENT in getStaticProps', async () => {
await writePage(`
Expand Down
4 changes: 2 additions & 2 deletions test/turbopack-build-tests-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -11026,10 +11026,10 @@
"GSP build errors production mode should handle non-serializable error in getStaticPaths",
"GSP build errors production mode should handle non-serializable error in getStaticProps"
],
"failed": [
"failed": [],
"pending": [
"GSP build errors production mode should fail build from module not found"
],
"pending": [],
"flakey": [],
"runtimeError": false
},
Expand Down

0 comments on commit 6964e22

Please sign in to comment.