fix runtime error flag

vercel · Oct 23, 2024 · 6b014c9 · 6b014c9
1 parent 3165a86
commit 6b014c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/next/src/client/components/react-dev-overlay/app/ReactDevOverlay.tsx b/packages/next/src/client/components/react-dev-overlay/app/ReactDevOverlay.tsx
@@ -10,6 +10,7 @@ import { ComponentStyles } from '../internal/styles/ComponentStyles'
 import { CssReset } from '../internal/styles/CssReset'
 import { RootLayoutMissingTagsError } from '../internal/container/root-layout-missing-tags-error'
 import type { Dispatcher } from './hot-reloader-client'
+import { RuntimeErrorHandler } from '../internal/helpers/runtime-error-handler'
 
 interface ReactDevOverlayState {
   reactError: SupportedErrorEvent | null
@@ -27,6 +28,7 @@ export default class ReactDevOverlay extends React.PureComponent<
   static getDerivedStateFromError(error: Error): ReactDevOverlayState {
     if (!error.stack) return { reactError: null }
 
+    RuntimeErrorHandler.hadRuntimeError = true
     return {
       reactError: {
         id: 0,

diff --git a/packages/next/src/client/components/react-dev-overlay/app/hot-reloader-client.tsx b/packages/next/src/client/components/react-dev-overlay/app/hot-reloader-client.tsx
@@ -566,8 +566,6 @@ export default function HotReload({
       const warning = errorDetails?.warning
       const stitchedError = getReactStitchedError(error)
 
-      RuntimeErrorHandler.hadRuntimeError = true
-
       dispatch({
         type: ACTION_UNHANDLED_ERROR,
         reason: stitchedError,