-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix sourcemaps for async Turbopack chunks (#72827)
Works around nodejs/node#52102 Webpack will be harder to patch and I don't know yet where the Webpack runtime is using `vm.runInThisContext`. Best way to observe change is in #71909 and `pnpm test-dev-turbo test/development/app-dir/dynamic-io-dev-errors/ -t "should display error when component accessed data without suspense boundary"`. Before: ``` Error: [...] at Page [Server] (<anonymous>) at InnerLayoutRouter (.next/server/chunks/ssr/[root of the server]__088b8c._.js) ``` After: ``` Error: [...] at Page [Server] (<anonymous>) at InnerLayoutRouter (node_modules/.pnpm/file+..+next-repo-2186278d37ae48e2b1397aa86060054592669ed9909b91e96c5af049d12c04c3+packages+n_vk62popbath6ofshgazcbhzdoe/node_modules/next/dist/src/client/components/layout-router.tsx:324:2) ``` Next step is figuring out why the now sourcemapped frames aren't ignore-listed.
- Loading branch information
Showing
4 changed files
with
26 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
...urbopack-tests/tests/snapshot/runtime/default_build_runtime/output/[turbopack]_runtime.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.