Skip to content

Commit

Permalink
Update with-react-bootstrap to be Turbopack compatible (#62773)
Browse files Browse the repository at this point in the history
## What?

This example used the legacy `~` operator which is no longer required in
latest webpack.

In case you land here trying Turbopack and running into the can't
resolve error this will be useful to know:

If you still need `~` it can be aliased using the `resolveAlias` option
in Turbopack:


```
module.exports = {
  experimental: {
    turbo: {
      resolveAlias: {
        '~*': '*',
      },
    },
  },
}
```

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2673
  • Loading branch information
timneutkens authored Mar 3, 2024
1 parent f2d4d04 commit 8c2edb4
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
1 change: 1 addition & 0 deletions examples/with-react-bootstrap/pages/_app.jsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import "bootstrap/dist/css/bootstrap.min.css";
import "../style/index.css";

export default function MyApp({ Component, pageProps }) {
Expand Down
3 changes: 0 additions & 3 deletions examples/with-react-bootstrap/style/index.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/* ensure all pages have Bootstrap CSS */
@import "~bootstrap/dist/css/bootstrap.min.css";

.md-container {
max-width: 800px;
padding-top: 2rem;
Expand Down
2 changes: 2 additions & 0 deletions examples/with-reactstrap/pages/_app.jsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import "bootstrap/dist/css/bootstrap.min.css";

import "../styles/index.css";

export default function MyApp({ Component, pageProps }) {
Expand Down
3 changes: 0 additions & 3 deletions examples/with-reactstrap/styles/index.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/* ensure all pages have Bootstrap CSS */
@import "~bootstrap/dist/css/bootstrap.min.css";

.md-container {
max-width: 800px;
padding-top: 2rem;
Expand Down

0 comments on commit 8c2edb4

Please sign in to comment.