-
Notifications
You must be signed in to change notification settings - Fork 27k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove default fallback behavior when route group is missing a default (
#62370) This test case was added in #59752, but this doesn't seem like the correct behavior. The original PR was intended to be smart about resolving `/default.tsx` to a route group default (e.g. `/(foo)/default.tsx`) when one wasn't specified. But since the route group is creating a new hierarchy in the tree and defines its own layout, if the route group layout doesn't specify a default, then the not found behavior seems correct. To fix unexpected not-found behavior in this case, you should specify a default at the same level as the layout where the missing slot(s) might be rendered. Closes NEXT-2565
- Loading branch information
Showing
15 changed files
with
5 additions
and
257 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletions
5
.../interception-route-groups/app/(level1)/(level2)/(level3)/@slot/(...)photos/[id]/page.tsx
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
test/e2e/app-dir/interception-route-groups/app/(level1)/(level2)/(level3)/@slot/default.tsx
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
test/e2e/app-dir/interception-route-groups/app/(level1)/(level2)/(level3)/layout.tsx
This file was deleted.
Oops, something went wrong.
9 changes: 0 additions & 9 deletions
9
...e2e/app-dir/interception-route-groups/app/(level1)/(level2)/(level3)/photos/[id]/page.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
...terception-route-groups/app/nested/(level1)/(level2)/@intercepted/(.)photos/[id]/page.tsx
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...e/app-dir/interception-route-groups/app/nested/(level1)/(level2)/@intercepted/default.tsx
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
test/e2e/app-dir/interception-route-groups/app/nested/(level1)/(level2)/layout.tsx
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
test/e2e/app-dir/interception-route-groups/app/nested/(level1)/(level2)/photos/[id]/page.tsx
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
test/e2e/app-dir/interception-route-groups/app/nested/default.tsx
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
test/e2e/app-dir/interception-route-groups/app/nested/page.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
138 changes: 0 additions & 138 deletions
138
test/e2e/app-dir/interception-route-groups/interception-route-groups.test.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters