Fix: Non-writable pages/_app breaks build (#24849)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
vercel · May 10, 2021 · 9e87596 · 9e87596
1 parent 8682705
commit 9e87596
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/next/build/webpack/loaders/next-serverless-loader/page-handler.ts b/packages/next/build/webpack/loaders/next-serverless-loader/page-handler.ts
@@ -412,7 +412,7 @@ export function getPageHandler(ctx: ServerlessHandlerCtx) {
 
       if (err.code === 'ENOENT') {
         res.statusCode = 404
-      } else if (err.code === 'DECODE_FAILED') {
+      } else if (err.code === 'DECODE_FAILED' || err.code === 'ENAMETOOLONG') {
         // TODO: better error?
         res.statusCode = 400
       } else {

diff --git a/packages/next/next-server/server/next-server.ts b/packages/next/next-server/server/next-server.ts
@@ -1255,7 +1255,7 @@ export default class Server {
         return
       }
     } catch (err) {
-      if (err.code === 'DECODE_FAILED') {
+      if (err.code === 'DECODE_FAILED' || err.code === 'ENAMETOOLONG') {
         res.statusCode = 400
         return this.renderError(null, req, res, '/_error', {})
       }

diff --git a/packages/next/server/lib/find-page-file.ts b/packages/next/server/lib/find-page-file.ts
@@ -1,9 +1,9 @@
 import { join, sep as pathSeparator, normalize } from 'path'
 import chalk from 'chalk'
-import { isWriteable } from '../../build/is-writeable'
 import { warn } from '../../build/output/log'
 import { promises } from 'fs'
 import { denormalizePagePath } from '../../next-server/server/normalize-page-path'
+import { fileExists } from '../../lib/file-exists'
 
 async function isTrueCasePagePath(pagePath: string, pagesDir: string) {
   const pageSegments = normalize(pagePath).split(pathSeparator).filter(Boolean)
@@ -31,14 +31,14 @@ export async function findPageFile(
       const relativePagePath = `${page}.${extension}`
       const pagePath = join(rootDir, relativePagePath)
 
-      if (await isWriteable(pagePath)) {
+      if (await fileExists(pagePath)) {
         foundPagePaths.push(relativePagePath)
       }
     }
 
     const relativePagePathWithIndex = join(page, `index.${extension}`)
     const pagePathWithIndex = join(rootDir, relativePagePathWithIndex)
-    if (await isWriteable(pagePathWithIndex)) {
+    if (await fileExists(pagePathWithIndex)) {
       foundPagePaths.push(relativePagePathWithIndex)
     }
   }